laravel:iterating-on-code

Files (1)

• SKILL.md

SKILL.md (first lines)

# Iterating on Code

AI-generated code rarely perfect on first try. Effective iteration gets you from "close" to "exactly right."

## Incorrect Code

### Vague Feedback
"This doesn't work"

### Specific Feedback
"The validation is incorrect:

**Current code:**
```php
'email' => 'required|email|unique:users'
```

**Problem:** This allows updating a user's email to another user's existing email. The unique rule needs to ignore the current user.

**Fix:**
```php
'email' => [
    'required',
    'email',
    Rule::unique('users')->ignore($this->user()->id)
]
```

This allows the user to keep their own email but prevents duplicates with other users."

**Why it works:** Identifies the specific problem, explains why it's wrong, shows the correct solution.

## Incomplete Code

### Vague
"Something's missing"

### Specific
"The OrderService is missing error handling:

**Current implementation:**
```php
public function createOrder(array $data): Order
{
    $order = Order::create($data);
    $this->processPayment($order);
    return $order;
}
```

**Missing:**
1. Transaction wrapping (payment and order creation should be atomic)
2. Payment failure handling
3. Inventory validation before creating order
4. Event dispatching after successful creation

**Add:**
```php
DB::transaction(function () use ($data) {
    $this->validateInventory($data['items']);
    $order = Order::create($data);
    $this->processPayment($order);
    event(new OrderCreated($order));
    return $order;
});
```

Plus add try/catch for payment failures."

**Why it works:** Lists specific missing pieces with context and shows how to add them.

## Refinement Needed

### Vague
"Make it better"

### Specific
"Refine the query for better performance:

**Current:**
```php
$products = Product::all()->filter(function ($product) {
    return $product->isActive() && $product->inStock();
});
```

**Issues:**
- Loads all products into memory (inefficient for large datasets)
- Filters in PHP instead of database
- Calls methods on each product (N+1 potential)

**Refined:**
```php
$products = Product::query()
    ->where('active', true)
    ->where('stock_quantity', '>', 0)
    ->get();
```

Move filtering to database, use indexed columns, avoid loading unnecessary data."

**Why it works:** Explains what needs refinement and why, shows the improved version.

## Style Issues

### Vague
"Follow our style guide"

### Specific
"Update to match our coding standards:

**Current:**
```php
public function get_user_orders($userId) {
    return Order::where('user_id', $userId)->get();
}
```

**Style issues:**

From jpcaparas/superpowers-laravel, MIT.

More from jpcaparas/superpowers-laravel