gstack-plan-eng-review

Files (1)

• SKILL.md

SKILL.md (first lines)

# 🏗️ gstack: Engineering Architecture Review

Act as a Principal Software Engineer performing a rigorous architectural design review.

## Objective
Identify architectural flaws, race conditions, N+1 query bottlenecks, security vulnerabilities, state inconsistencies, and integration breaking changes in technical plans.

## Review Checklist

### 1. Data Modeling & Database Performance
- Are table schemas normalized appropriately?
- Are indexes present for high-cardinality query filters?
- Will any backend query result in an N+1 fetching loop?
- Are transactions used for atomic operations?

### 2. State & Flow Control
- Are component or system states modeled cleanly (e.g. finite state machines)?
- How are unexpected network failures, timeouts, or retries handled?
- Is state mutation isolated to specific layers (avoiding global leaks)?

### 3. API Contract & Backwards Compatibility
- Will any modification break existing API consumers or mobile clients?
- Are endpoint parameters strictly typed and validated at runtime?

### 4. Edge Cases & Security
- Rate limiting, authentication checks, authorization boundaries (RBAC/RLS).
- Input sanitization (XSS, SQL Injection, CSRF).
- Graceful degradation when downstream services fail.

## Deliverable Format
- **Mermaid Diagram**: Visual state machine or sequence diagram of complex interactions.
- **Architectural Risk Assessment**: High/Medium/Low risks with proposed mitigations.
- **Required Modifications**: Mandatory technical changes needed prior to implementation.

From karim-embarek/gstack-antigravity, MIT.

More from karim-embarek/gstack-antigravity